Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

fix(@schematics/angular): Restrict some schematics to type of applica… - #790

Merged
hansl merged 1 commit into
angular:masterfrom
Brocco:prj-app-error
Apr 26, 2018
Merged

hansl merged 1 commit into
angular:masterfrom
Brocco:prj-app-error

Conversation

@Brocco

@Brocco Brocco commented Apr 26, 2018

Copy link
Copy Markdown
Contributor

…tion

fixes #789

@Brocco
Brocco requested a review from hansl April 26, 2018 18:50
return (host: Tree, context: SchematicContext) => {
const clientProject = getClientProject(host, options);
if (clientProject.projectType !== 'application') {
throw new SchematicsException(`App shell requires a project type of "application".`);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Universal requires?

throw new SchematicsException(`Invalid project name (${options.project})`);
}
if (project.projectType !== 'application') {
throw new SchematicsException(`App shell requires a project type of "application".`);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

service worker requires?

@hansl
hansl merged commit b91ba17 into angular:master Apr 26, 2018
@Brocco
Brocco deleted the prj-app-error branch April 26, 2018 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restrict usage of some schematics to project type of "application"

4 participants